Skip to content

Change request_cls to prevent unintended bytes -> str conversion #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Change request_cls to prevent unintended bytes -> str conversion #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mocket/mocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ def data(self):
return self

response_index = 0
request_cls = str
request_cls = bytes
response_cls = Response
responses = None
_served = None
Expand Down
12 changes: 12 additions & 0 deletions tests/main/test_mocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,18 @@ def test_raise_exception(self):
with self.assertRaises(IOError):
entry.get_response()

def test_collect_last_request(self):
addr = ("localhost", 80)

entry = MocketEntry(addr, True)
Mocket.register(entry)
with Mocketizer():
_so = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
_so.connect(addr)
_so.sendall(b"data\r\n")
_so.close()
self.assertEqual(Mocket.last_request(), b"data\r\n")

def test_subsequent_recv_requests_have_correct_length(self):
addr = ("localhost", 80)
Mocket.register(MocketEntry(addr, [b"Long payload", b"Short"]))
Expand Down