Polygon as class#35
Merged
mindflayer merged 5 commits intomainfrom Dec 11, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Polygon factory function into a proper class that extends the Poly cdef class, providing better Shapely API compatibility and improved type hints.
Key Changes
- Converted
Polygonfrom a factory function to a class that inherits fromPoly - Added comprehensive type hints for parameters using Python's
typingmodule - Enhanced documentation with detailed docstrings for the class and
__init__method
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
3 tasks
Contributor
|
@mindflayer I've opened a new pull request, #36, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Fix Python 3.8 compatibility: Replace tuple[float, float] with Tuple[float, float] Co-authored-by: mindflayer <527325+mindflayer@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mindflayer <527325+mindflayer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.