Standardize error handling for None in Point.nearest_points() and Point.shortest_line()#45
Merged
mindflayer merged 4 commits intoshapely-nearest-points-shortest-linefrom Jan 17, 2026
Conversation
…nt.shortest_line() Co-authored-by: mindflayer <527325+mindflayer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on adding Shapely's nearest_points and shortest_line
Standardize error handling for None in Point.nearest_points() and Point.shortest_line()
Jan 17, 2026
Owner
|
@copilot the |
mindflayer
requested changes
Jan 17, 2026
Owner
|
@copilot are we testing the new checks? |
Contributor
Author
Contributor
Author
Yes, the new
Both tests verify that |
ae62184
into
shapely-nearest-points-shortest-line
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nonechecks to Point class'snearest_points()methodNonechecks to Point class'sshortest_line()methodelseclauses (feedback from review)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.