Conversation
…valley/wukong-cli into feat/tui-logs
It doesn't work work well with Text Wrap
onimsha
approved these changes
Aug 30, 2023
Contributor
onimsha
left a comment
onimsha
left a comment
There was a problem hiding this comment.
For the MVP purpose, this is good. We have a baseline to implement further improvements in the next releases.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jk-gan, onimsha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: PXP-579
What's Changed
Added
Fixed