Skip to content

PXP-616: [CLI] Log Entries is not reset after a new namespace or a new version is selected#152

Merged
jk-gan merged 4 commits intomainfrom
fix/refetch-logs
Oct 2, 2023
Merged

PXP-616: [CLI] Log Entries is not reset after a new namespace or a new version is selected#152
jk-gan merged 4 commits intomainfrom
fix/refetch-logs

Conversation

@jk-gan
Copy link
Contributor

@jk-gan jk-gan commented Oct 2, 2023

Summary

There are few bugs found during my discoveries, so I made a PR to fix them together.

Ticket: PXP-616

What's Changed

Fixed

  • Fix the log entries and log_entries_length is not reset after new namespace or new version is selected
  • Fix the duplicated gcloud API call after a new namespace is selected
  • Fix the gcloud API not being called after a new namespace or a new version is selected when the tailing is disabled

@jk-gan jk-gan requested review from mfauzaan and onimsha October 2, 2023 06:43
@jk-gan jk-gan self-assigned this Oct 2, 2023
@jk-gan jk-gan added bug Something isn't working bugfix Bug fix labels Oct 2, 2023
@jk-gan jk-gan changed the title Bug Fixes PXP-616: [CLI] Log Entries is not reset after a new namespace or a new version is selected Oct 2, 2023
Copy link
Contributor

@mfauzaan mfauzaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jk-gan, mfauzaan

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jk-gan jk-gan merged commit 53e25a9 into main Oct 2, 2023
@sauron-droid sauron-droid deleted the fix/refetch-logs branch October 2, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working bugfix Bug fix size/M

Development

Successfully merging this pull request may close these issues.

3 participants