Skip to content

PXP-676: [CLI] Skip workflow step on application init if empty#203

Merged
onimsha merged 2 commits intomainfrom
fix/skip-workflow-on-application-init-if-git-folder-not-found
Mar 6, 2024
Merged

PXP-676: [CLI] Skip workflow step on application init if empty#203
onimsha merged 2 commits intomainfrom
fix/skip-workflow-on-application-init-if-git-folder-not-found

Conversation

@mfauzaan
Copy link
Contributor

@mfauzaan mfauzaan commented Mar 6, 2024

Summary

Currently, when running the application init, if there are no Github Actions workflows in the .github folder, the CLI will return error. To handle this case skip the workflow action if there is no file in the directly or path is not found

Ticket: PXP-676

What's Changed

Changed

  • Skip workflow selection if yaml file is not found in the .github directory
  • Skip workflow selection if .github file is not found

@mfauzaan mfauzaan requested review from jk-gan and onimsha and removed request for onimsha March 6, 2024 09:10
@mfauzaan mfauzaan self-assigned this Mar 6, 2024
@mfauzaan mfauzaan requested a review from onimsha March 6, 2024 09:22
@mfauzaan mfauzaan added the bugfix Bug fix label Mar 6, 2024
@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mfauzaan, onimsha

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onimsha onimsha merged commit 8a626d8 into main Mar 6, 2024
@sauron-droid sauron-droid deleted the fix/skip-workflow-on-application-init-if-git-folder-not-found branch March 6, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants