Fix tiktoken compatibility with non-OpenAI models#155
Merged
kevin-mindverse merged 1 commit intomindverse:masterfrom Apr 7, 2025
Merged
Fix tiktoken compatibility with non-OpenAI models#155kevin-mindverse merged 1 commit intomindverse:masterfrom
kevin-mindverse merged 1 commit intomindverse:masterfrom
Conversation
yingapple
approved these changes
Apr 7, 2025
Contributor
yingapple
left a comment
yingapple
left a comment
There was a problem hiding this comment.
thanks for your contribution
Contributor
|
Great Job! |
kevin-mindverse
approved these changes
Apr 7, 2025
Heterohabilis
pushed a commit
to Heterohabilis/Second-Me
that referenced
this pull request
May 29, 2025
EOMZON
pushed a commit
to EOMZON/Second-Me
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When configuring custom models,
tiktokenmay fail to retrievetokenizersfor non-OpenAI models. Specifically,tokenizersfor models likeQwen2.5andClaudeare not available in thetiktokenlibrary, resulting in the following error:Solution
This PR adds compatibility handling by using the
cl100k_basetokenizer as a default fallback for models not supported bytiktoken. This approach ensures that operations requiring tokenization can proceed without errors for non-OpenAI models like Qwen2.5 and Claude.