fix: Wrong encoding on reading backend.log#171
Merged
kevin-mindverse merged 1 commit intomindverse:masterfrom Apr 9, 2025
Merged
fix: Wrong encoding on reading backend.log#171kevin-mindverse merged 1 commit intomindverse:masterfrom
kevin-mindverse merged 1 commit intomindverse:masterfrom
Conversation
Contributor
|
Good Job. We'll merge this pr if it pass the daily rebuild |
yingapple
approved these changes
Apr 9, 2025
doubleBlack2
pushed a commit
that referenced
this pull request
Apr 15, 2025
Heterohabilis
pushed a commit
to Heterohabilis/Second-Me
that referenced
this pull request
May 29, 2025
EOMZON
pushed a commit
to EOMZON/Second-Me
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170 by determining the encoding prior to read.
Tested successfully on Windows 11, and further testing on other environments might be necessary.
Note: This PR adds a new dependency, I am not sure if this is acceptable, as it may need people to rerun poetry install on upgrade.