Skip to content

Fix model download step being skipped during training#84

Merged
yingapple merged 2 commits intomindverse:masterfrom
vijaythecoder:fix-model-download-step
Mar 27, 2025
Merged

Fix model download step being skipped during training#84
yingapple merged 2 commits intomindverse:masterfrom
vijaythecoder:fix-model-download-step

Conversation

@vijaythecoder
Copy link
Copy Markdown
Contributor

Issue

The training process skips the model download step when the model directory exists but is missing required files (like config.json), causing training to fail later.

Fix

  • Added check for config.json file in addition to model directory
  • Automatically downloads model if directory or config is missing
  • Fixed error handling to use correct ProcessStep enum

Testing

Verified on Apple M4 Pro with 24GB RAM that:

  • Empty model directories trigger download
  • Directories missing config.json trigger download
  • UI correctly shows download progress

This resolves the issue where users manually place model files in the correct directory but training fails due to missing configuration files.

@vijaythecoder vijaythecoder marked this pull request as ready for review March 27, 2025 00:34
@yexiangle yexiangle self-requested a review March 27, 2025 02:08
Copy link
Copy Markdown
Contributor

@yingapple yingapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@yingapple yingapple merged commit f0da85a into mindverse:master Mar 27, 2025
1 check passed
@ScarletttMoon
Copy link
Copy Markdown
Collaborator

Hi @vijaythecoder 👋,

Thank you so much for your contribution to this PR! Your work is really appreciated. If you haven’t already, feel free to join our Discord community here: Discord Invite Link — it's a great place to connect with our team and other contributors, share ideas, and stay up to date with the project! You can find me as @scarlettt_moon there!

Looking forward to connecting! 😊

Heterohabilis pushed a commit to Heterohabilis/Second-Me that referenced this pull request May 29, 2025
* Fix model download step being skipped during training

* Fix ProcessStep enum in error case to use MODEL_DOWNLOAD instead of TRAIN
EOMZON pushed a commit to EOMZON/Second-Me that referenced this pull request Feb 1, 2026
* Fix model download step being skipped during training

* Fix ProcessStep enum in error case to use MODEL_DOWNLOAD instead of TRAIN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants