Fix model download step being skipped during training#84
Merged
yingapple merged 2 commits intomindverse:masterfrom Mar 27, 2025
Merged
Fix model download step being skipped during training#84yingapple merged 2 commits intomindverse:masterfrom
yingapple merged 2 commits intomindverse:masterfrom
Conversation
yexiangle
approved these changes
Mar 27, 2025
yingapple
approved these changes
Mar 27, 2025
Contributor
yingapple
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
yexiangle
approved these changes
Mar 27, 2025
Collaborator
|
Hi @vijaythecoder 👋, Thank you so much for your contribution to this PR! Your work is really appreciated. If you haven’t already, feel free to join our Discord community here: Discord Invite Link — it's a great place to connect with our team and other contributors, share ideas, and stay up to date with the project! You can find me as @scarlettt_moon there! Looking forward to connecting! 😊 |
Heterohabilis
pushed a commit
to Heterohabilis/Second-Me
that referenced
this pull request
May 29, 2025
* Fix model download step being skipped during training * Fix ProcessStep enum in error case to use MODEL_DOWNLOAD instead of TRAIN
EOMZON
pushed a commit
to EOMZON/Second-Me
that referenced
this pull request
Feb 1, 2026
* Fix model download step being skipped during training * Fix ProcessStep enum in error case to use MODEL_DOWNLOAD instead of TRAIN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The training process skips the model download step when the model directory exists but is missing required files (like
config.json), causing training to fail later.Fix
config.jsonfile in addition to model directoryTesting
Verified on Apple M4 Pro with 24GB RAM that:
This resolves the issue where users manually place model files in the correct directory but training fails due to missing configuration files.