Add Open Addressing Hash Map#12
Closed
hungcq wants to merge 5 commits intomindxhub:masterfrom
hungcq:master
Closed
Add Open Addressing Hash Map#12hungcq wants to merge 5 commits intomindxhub:masterfrom hungcq:master
hungcq wants to merge 5 commits intomindxhub:masterfrom
hungcq:master
Conversation
added 2 commits
June 1, 2020 20:34
Contributor
|
@vietduc01100001 Please help to take a look |
hellovietduc
suggested changes
Jun 5, 2020
src/Array.java
Outdated
Comment on lines
+25
to
+26
| public int itemAt(int index) { | ||
| if (index > size - 1) { |
There was a problem hiding this comment.
What if we pass -1, -2 or -3000 to this function? Would it throw an error? Or should we handle it nicely?
Comment on lines
+38
to
+39
| public boolean insert(int item, int index) { | ||
| if (index == size) { |
There was a problem hiding this comment.
Same as above, you should validate the index parameter.
src/Array.java
Outdated
Comment on lines
+56
to
+59
| if (arr.length == 0) { | ||
| arr = new int[1]; | ||
| return; | ||
| } |
There was a problem hiding this comment.
You won't need to handle this edge case if you choose a good default capacity.
src/Array.java
Outdated
| return; | ||
| } | ||
| if (size > arr.length) { | ||
| int[] newArr = new int[arr.length * 2]; |
There was a problem hiding this comment.
Avoid hard-coding the grow factor 2 into the function.
src/Array.java
Outdated
Comment on lines
+77
to
+78
| public int removeAt(int index) { | ||
| if (index >= size - 1) { |
There was a problem hiding this comment.
Validate the index parameter when it's a negative integer.
src/Array.java
Outdated
Comment on lines
+92
to
+93
| if (size <= arr.length / 4) { | ||
| int[] newArr = new int[arr.length / 2]; |
There was a problem hiding this comment.
Same as above, avoid hard-coding "magic numbers".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.