Add symfony/http-foundation as a runtime dependency for mineadmin/support#164
Draft
Add symfony/http-foundation as a runtime dependency for mineadmin/support#164
symfony/http-foundation as a runtime dependency for mineadmin/support#164Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/mineadmin/components/sessions/f68b3125-183d-4cf6-8d98-7a039e1df3a0 Co-authored-by: zds-s <49744633+zds-s@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add symfony/http-foundation dependency for hyperf/testing
Add Mar 30, 2026
symfony/http-foundation as a runtime dependency for mineadmin/support
Member
|
@copilot 6.4 有点太低了吧,我现在是支持 8.1-8.3 的。未来也是要计划支持到最新 8.5 的 |
Agent-Logs-Url: https://github.com/mineadmin/components/sessions/6f3f18c5-1a9e-4a25-b40e-6a8d1f2b7c2d Co-authored-by: zds-s <49744633+zds-s@users.noreply.github.com>
Author
已调整为 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mineadmin/supportusesSymfony\Component\HttpFoundation\HeaderUtilsandIpUtilsat runtime, but the package was only being pulled in transitively viahyperf/testingfromrequire-dev. Production installs withcomposer install --no-devcould therefore miss the dependency and fail at runtime.Runtime dependency declaration
symfony/http-foundationtosrc/Support/composer.jsonso the Support component declares the dependency it actually uses.composer.jsonto keep the aggregated package manifest aligned with component-level requirements.Version compatibility
^6.4 || ^7.0instead of pinning only to^6.4.Affected runtime path
Mine\Support\Request\ClientIpRequestTraitimports and calls HttpFoundation utilities for forwarded header parsing and trusted proxy IP checks.composer install --no-devnow includessymfony/http-foundation, avoiding missing-class failures in the Support request IP handling path without unnecessarily restricting supported Symfony versions.⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.