Remap lines lazily in mixin targets that have not been decompiled yet #2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good 👍 Please fix the ktlint error and I'll merge it |
makamys
force-pushed
the
remap-bytecode-lines-lazily
branch
from
9b02a84 to
91ca0de
Compare
Contributor
Author
|
Whoops, fixed it. |
RedNesto
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2026 (comment). Well, mostly.
Prior to this commit, switching to a stack frame inside a not yet decompiled class would take you to the wrong line, and switching to the same stack frame would always take you to the same wrong line until you restart the debug session.
With this commit, the first time you switch, you will still be taken to the wrong line, but on subsequent switches you will be taken to the correct line. The same thing happens even without the plugin, so I assume this is just a limitation of IntelliJ that can't be helped.