Support split strings within inspections & method target references

[FxMorin]

Description:

Currently some inspections don't support strings that have been split to support a line width limit, same goes for Injection method targets.

Changes:

Removed multiple direct PsiLiteral checks which where not needed, since all calls would lead to PsiElement.constantStringValue, which will return null if its not suppose to.

Now, all these calls will use the ConstantExpressionVisitor.compute call which takes care of the split string logic.

Examples:

Method Reference

Before - Single (Expected behaviour)

Before - Split

After - Split

AmbiguousReferenceInspection

Before

After

InvalidMemberReferenceInspection

Before

After

UnnecessaryQualifiedMemberReferenceInspection

Before

After

[Earthcomputer]

Are you sure that checks for PsiLiteral weren't the only problem? The constantEvaluationHelper is already supposed to handle string concatenation, see ConstantExpressionVisitor.compute

[FxMorin]

Are you sure that checks for PsiLiteral weren't the only problem? The constantEvaluationHelper is already supposed to handle string concatenation, see ConstantExpressionVisitor.compute

I was not aware of this. I just tested it, and you're right. I'll remove the changes to PsiElement.constantStringValue