Minor cleanup everywhere #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-gh
force-pushed
the
minor-cleanup
branch
from
8e67d00 to
718dd91
Compare
Contributor
|
You might want to address some occurrences of |
Contributor
Author
|
@PaleoCrafter Thanks, done. |
DenWav
reviewed
Sep 13, 2017
|
|
||
| import com.demonwav.mcdev.util.gson | ||
| import com.demonwav.mcdev.util.SemanticVersion | ||
| import com.demonwav.mcdev.util.gson |
Member
There was a problem hiding this comment.
This seems weird to me. Does uppercase sort before lowercase? Seems like imports should be sorted case-insensitive to me.
Contributor
Author
There was a problem hiding this comment.
That's what IntelliJ IDEA does when sorting the imports. It seems like they are sorted case-sensitive, but since this is what your IntelliJ code style does, I'm not sure we should bother and keep this different manually
- Fixed wrong package declaration - Replaced some long if-else chains with when - Removed explicit String.trim() predicate (probably from Java->Kotlin conv.) - Moved some assignments / return statements outside of if/try blocks - Other minor cleanup to use more Kotlin features
stephan-gh
force-pushed
the
minor-cleanup
branch
from
abd2c77 to
0885eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should be pretty straightforward. No functional change. Just some minor cleanup to fix some warnings reported by IntelliJ inspections (but not all of them, because some don't make sense). Opening this pull request if you want to take a quick look @DemonWav.
I avoided touching any Forge side-only inspections since you have a branch somewhere that removes/changes them.