Skip to content

Add API Version flag for 1.13+ Bukkit plugins #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Add API Version flag for 1.13+ Bukkit plugins #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/kotlin/com/demonwav/mcdev/platform/bukkit/BukkitTemplate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,14 @@ object BukkitTemplate {
properties.setProperty("HAS_WEBSITE", "true")
}

// Plugins targeting 1.13 or newer need an explicit api declaration flag
// Unfortunately this flag has no contract to match any specific API version
val mcVer = settings.minecraftVersion.substring(0, 4).toDoubleOrNull()
if (mcVer != null && mcVer >= 1.13) {
properties.setProperty("API_VERSION", "1.13")
properties.setProperty("HAS_API_VERSION", "true")
}

BaseTemplate.applyTemplate(project, file, MinecraftFileTemplateGroupFactory.BUKKIT_PLUGIN_YML_TEMPLATE, properties, true)
}
}
3 changes: 3 additions & 0 deletions src/main/resources/fileTemplates/j2ee/bukkit_plugin_description_file.yml.ft
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: ${NAME}
version: ${VERSION}
main: ${MAIN}
#if (${HAS_API_VERSION})
api-version: ${API_VERSION}
#end
#if (${HAS_PREFIX})
prefix: ${PREFIX}
#end
Expand Down