Skip to content

Disable entity constructor inspection for EntityFX (particle entities) #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Disable entity constructor inspection for EntityFX (particle entities) #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c131e15
add EntityFx to McpConstants
anatawa12 Jul 2, 2019
99f7624
disable EntityConstructorInspection for EntityFX
anatawa12 Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/kotlin/com/demonwav/mcdev/platform/mcp/inspections/EntityConstructorInspection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ class EntityConstructorInspection : BaseInspection() {
return
}

if (aClass.extendsOrImplements(McpConstants.ENTITY_FX)) {
return
}

val module = ModuleUtilCore.findModuleForPsiElement(aClass) ?: return

val instance = MinecraftFacet.getInstance(module) ?: return
Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/com/demonwav/mcdev/platform/mcp/util/McpConstants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ object McpConstants {

const val TEXT_FORMATTING = "net.minecraft.util.text.TextFormatting"
const val ENTITY = "net.minecraft.entity.Entity"
const val ENTITY_FX = "net.minecraft.client.particle.EntityFX"
const val WORLD = "net.minecraft.world.World"
const val ITEM_STACK = "net.minecraft.item.ItemStack"
const val BLOCK = "net.minecraft.block.Block"
Expand Down