New branch protection syntax #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerenmartius
force-pushed
the
new-branch-protection-syntax
branch
2 times, most recently
from
de24e53 to
cfb0ea2
Compare
mariux
reviewed
Jan 13, 2020
main.tf
Outdated
Comment on lines
152
to
163
| team_admin = [for i in var.admin_team_ids : { | ||
| team_id = i, | ||
| permission = "admin" | ||
| }] | ||
| team_push = [for i in var.push_team_ids : { | ||
| team_id = i, | ||
| permission = "push" | ||
| }] | ||
| team_pull = [for i in var.pull_team_ids : { | ||
| team_id = i, | ||
| permission = "pull" | ||
| }] |
Member
There was a problem hiding this comment.
i think it was more readable before... but just an opinion ;)
mariux
reviewed
Jan 13, 2020
mariux
reviewed
Jan 13, 2020
main.tf
Outdated
Comment on lines
94
to
95
| users = lookup(local.branch_protection_rules[count.index].restrictions, "users", []) | ||
| teams = lookup(local.branch_protection_rules[count.index].restrictions, "teams", []) |
Member
There was a problem hiding this comment.
is default here empty array or null?
mariux
approved these changes
Jan 13, 2020
Member
mariux
left a comment
mariux
left a comment
There was a problem hiding this comment.
lgmt... unsure about defaults in blocks when everything is empty... but let's see it fail and fix...
Member
|
closing in favor of #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to remove the list from branch_protections and to work with objects only.