Add issue_labels_create argument #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariux
force-pushed
the
mariux/do-not-always-create-issue-labels
branch
from
cdebbf6 to
000f75d
Compare
mariux
force-pushed
the
mariux/do-not-always-create-issue-labels
branch
from
000f75d to
dda270f
Compare
soerenmartius
approved these changes
May 13, 2020
Member
soerenmartius
left a comment
soerenmartius
left a comment
There was a problem hiding this comment.
lgtm! Please see my comment for clarification
| variable "issue_labels_create" { | ||
| description = "Specify whether you want to force or suppress the creation of issues labels." | ||
| type = bool | ||
| default = null |
Member
There was a problem hiding this comment.
Wasn't set enabled per default previously?
Member
Author
There was a problem hiding this comment.
from description up there:
This changes the default of this behavior to only create/import issues when issues are enabled or issue labels are specified.
;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
When disabling issues via
has_issues = falsethe module will still import Github issue labels. which creates a bunch of unneeded resources.Implemented solution
This changes the default of this behavior to only create/import issues when issues are enabled or issue labels are specified.
A new argument
issue_labels_createwas added to disable issue label creation completely or to force creating issue labels even ifhas_issues == falseBreaking Change
This could be considered a breaking change as it might delete issue_labels that have been imported before.
You could prevent this by actively setting
issue_labels_create = true.