Skip to content

Revert "Fix dependency issue when assigning teams by name" #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mariux merged 4 commits into from
May 26, 2020
Merged

Revert "Fix dependency issue when assigning teams by name" #37

mariux merged 4 commits into from
May 26, 2020

Conversation

@mariux
Copy link
Member

@mariux mariux commented May 25, 2020 •
edited
Loading

Reverts #36

this fix will always show a plan and recreate resources... need to reimplement differently...

breaking change

  • this is a breaking change of a non-usable feature. I will try to figure out some cool hack to make it happen anyway but in the meantime make it an explicit execption to first create teams and then assign them to repositories..

@mariux mariux requested a review from soerenmartius as a code owner May 25, 2020 23:10
@mariux mariux force-pushed the revert-36-mariux/fix-dependency-in-team-by-name branch from 667d743 to 38a833d Compare May 26, 2020 00:16
soerenmartius
soerenmartius approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mariux mariux merged commit 7507818 into master May 26, 2020
@mariux mariux deleted the revert-36-mariux/fix-dependency-in-team-by-name branch May 26, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soerenmartius soerenmartius soerenmartius approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mariux @soerenmartius