fix: resolve nil pointer dereference warnings in forward_test.go#606
Merged
robinbraemer merged 1 commit intomasterfrom Dec 8, 2025
Merged
fix: resolve nil pointer dereference warnings in forward_test.go#606robinbraemer merged 1 commit intomasterfrom
robinbraemer merged 1 commit intomasterfrom
Conversation
Deploying gate-minekube with
|
| Latest commit: |
a26408b
|
| Status: | ⚡️ Build in progress... |
robinbraemer
force-pushed
the
fix/lint-forward-test-nil-check
branch
from
e6c0f9a to
7540505
Compare
Replace t.Fatal() nil checks with require.NotNil() which the static analyzer understands stops execution, fixing SA5011 warnings.
robinbraemer
force-pushed
the
fix/lint-forward-test-nil-check
branch
from
7540505 to
a26408b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes staticcheck SA5011 warnings about possible nil pointer dereference in forward_test.go.
The static analyzer doesn't recognize that
t.Fatal()stops execution, so it flags potential nil pointer access after nil checks. Adding explicitreturnstatements aftert.Fatal()calls helps the analyzer understand that execution stops.Fixes lint errors: