fix(proxy): forward backend register/unregister packets to client#672
Merged
robinbraemer merged 1 commit intominekube:masterfrom Mar 10, 2026
Merged
Conversation
The backend play handler was incorrectly sending minecraft:register and minecraft:unregister packets back to the server instead of forwarding them to the client. Mods like Axiom rely on receiving these packets from the backend to know which plugin message channels are available.
Member
|
THANKS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backendPlaySessionHandler.handlePluginMessageto forwardminecraft:registerandminecraft:unregisterpackets from the backend server to the client, instead of incorrectly sending them back to the server.Problem
When a backend server sends
minecraft:registerplugin messages to declare supported channels, the proxy was erroneously writing these packets back to the server instead of forwarding them to the connected client.This broke mods like Axiom that rely on receiving these registration packets to know which plugin message channels the backend supports.
Fix
The handler now correctly calls
forwardToPlayer(pc, packet)to send register/unregister packets to the client, matching the intended behavior described in the updated comment.Test Plan
TestBackendPlayRegisterForwardsToPlayerunit testgo build ./...passesgo test ./pkg/edition/java/proxypasses