fix: handle bare IPv6 addresses in proxy protocol header#673
Merged
robinbraemer merged 1 commit intomasterfrom Mar 10, 2026
Merged
fix: handle bare IPv6 addresses in proxy protocol header#673robinbraemer merged 1 commit intomasterfrom
robinbraemer merged 1 commit intomasterfrom
Conversation
When a client connects via IPv6 through Connect, the address string (e.g. "2a09:bac6:d73f:28::4:31d") has no brackets or port. net.SplitHostPort returns "too many colons in address" for this format, which was unhandled, causing splitHostPort to return an empty host and triggering a panic in protoutil.convert.
Deploying gate-minekube with
|
| Latest commit: |
36f979d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a292d418.gate-minekube.pages.dev |
| Branch Preview URL: | https://fix-670-ipv6-proxy-protocol.gate-minekube.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxyProtocol: truenet.SplitHostPortreturns "too many colons in address" for bare IPv6 strings like2a09:bac6:d73f:28::4:31d(no brackets, no port). This was unhandled innetutil.splitHostPort, causing it to return an empty host, which then panicked inprotoutil.convertTest plan
TestHostPort_BareIPv6innetutilverifying bare IPv6 addresses parse correctlyTestProxyHeaderusingconnect.Addrwith real IPv6 addresses from the issue