Skip to content

Preparations for release of preview version 3#950

Merged
michelebastione merged 5 commits intomini-software:masterfrom
michelebastione:preview3-release-setup
Apr 26, 2026
Merged

Preparations for release of preview version 3#950
michelebastione merged 5 commits intomini-software:masterfrom
michelebastione:preview3-release-setup

Conversation

@michelebastione
Copy link
Copy Markdown
Collaborator

@michelebastione michelebastione commented Apr 26, 2026

  • Renamed the MappingTemplater's ApplyTemplateAsync method overloads to FillTemplateAsync for keeping consistency with the OpenXmlTemplater respective methods' names
  • Updated packages references and removed the superfluous Newtonsoft.Json one from the MiniExcel.Ope nXml.Tests test project
  • Refactored benchmarks to be based off a 100,000 rows Excel file instead of a 1 million rows one, bringing their duration down from 6+ hours to 25 minutes.
  • Fixed benchmark.yml workflow file and bumping project version
  • Updated readmes and upgrade notes

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several project dependencies, increments the version to 2.0.0-preview.3, and renames template-related methods from 'ApplyTemplate' to 'FillTemplate'. It also removes the Newtonsoft.Json dependency from the test projects, replacing it with System.Text.Json or manual object construction. Feedback is provided regarding the migration to System.Text.Json in 'TestIssue370', where deserializing to a dictionary results in 'JsonElement' values instead of primitives. This change necessitates manual parsing in assertions and reduces the test's effectiveness; it is recommended to define the test data directly to preserve type fidelity.

Comment thread tests/MiniExcel.OpenXml.Tests/MiniExcelIssueTests.cs Outdated
Comment thread tests/MiniExcel.OpenXml.Tests/MiniExcelIssueTests.cs Outdated
…llTemplateAsync for keeping consistency with the OpenXmlTemplater methods' names

Previous method signatures were marked with ObsoleteAttribute to prevent current preview version builds to break, and will be subsequently removed.
@michelebastione michelebastione force-pushed the preview3-release-setup branch from 6049182 to 2571731 Compare April 26, 2026 15:39
@michelebastione
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 2.0.0-preview.3, renames template-related methods from ApplyTemplate to FillTemplate (marking the old ones as obsolete), and significantly refactors the documentation and benchmarks. Feedback focuses on several critical compilation errors caused by the removal of required using statements for source generators and compiler services. Additionally, there is a missing dependency for ToListAsync() in tests, a logic error in a test assertion regarding decimal precision, and a minor formatting issue.

Comment thread src/MiniExcel.OpenXml/FluentMapping/Api/MappingImporter.cs
Comment thread src/MiniExcel.OpenXml/FluentMapping/Api/MappingExporter.cs
Comment thread src/MiniExcel.OpenXml/FluentMapping/Api/MappingTemplater.cs
Comment thread tests/MiniExcel.OpenXml.Tests/MiniExcelIssueAsyncTests.cs
Comment thread tests/MiniExcel.OpenXml.Tests/MiniExcelIssueTests.cs Outdated
Comment thread tests/MiniExcel.OpenXml.Tests/MiniExcelIssueTests.cs Outdated
…nXml.Tests test project, also deleting pointless json serialization from some tests
…ead of a 1 million rows one

This reduces the benchmarking duration from 6 hours to 25 minutes.
Removed the suprefluous README-NuGet.md file from the solution, revised the actual README.md file included in the nuget package and updated minor details in the README-V2.md and V2-Upgrade-Notes.md files.
@michelebastione michelebastione force-pushed the preview3-release-setup branch from 5168483 to 1040113 Compare April 26, 2026 16:24
@michelebastione michelebastione merged commit b4d8e61 into mini-software:master Apr 26, 2026
3 checks passed
@michelebastione michelebastione deleted the preview3-release-setup branch April 26, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant