Refactoring of string data handling in OpenXmlWriter#961
Merged
michelebastione merged 10 commits intoMay 17, 2026
Merged
Conversation
Corrected oversight that prevented numerical string to be read as text by Excel when exported even if exported with the format `"@"`
Modifies the cell witing process of string content replacing the <v> tag with <is><t> tags and changes the cell data type from "str" to "inlineStr" in order to adhere to the OpenXml specification for inlined strings
…nserting and altering sheets
Implemented shared strings handling across the OpenXmlWriter and wired it to the new OpenXmlConfiguration option StringStorageMode.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the OpenXml implementation to support a new StringStorageMode (Inline vs. Shared), updates namespaces for consistency, and improves resource disposal in MiniExcelStreamWriter. Key changes include the introduction of shared string support during export, enhanced sheet name validation, and the consolidation of OpenXml API classes. Feedback from the reviewer highlights several critical areas for improvement: ensuring consistent XML encoding by moving it to the XML generation layer rather than the value retrieval stage, correcting the count attribute in the shared strings table, and fixing typos in exception and error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inlineStrdata type instead of thestrone and replacing the<v>tag with the<is><t>for their contents.OpenXmlConfigurationoptionStringStorageModeOpenXmlExportermethods