Fixed issue with generated documents unable to be accessed thrugh OleDb connector#962
Merged
michelebastione merged 2 commits intoMay 17, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenXml style builders to include mandatory attributes (numFmtId, fontId, fillId, borderId, and xfId) in xf elements to improve compatibility with tools like OleDb. Additionally, it refactors a large number of asynchronous tests to use non-blocking patterns such as ToListAsync and await foreach instead of ToBlockingEnumerable. Feedback was provided regarding the MinimalSheetStyleBuilder to reduce code duplication by using a local helper function for writing xf elements and to ensure consistency in loops not covered by the current diff.
…le builders OleDb requires these `<xf>` elements to be well formed in order to successfully estabilsh a connection to the Excel document
michelebastione
force-pushed
the
fix-issue-759
branch
from
8938ec6 to
81c4467
Compare
michelebastione
added a commit
that referenced
this pull request
May 17, 2026
…e builders Mirrors #962 on the maintenance branch to fix OleDb unable to connect to documents generated through MiniExcel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added required attributes to empty
cellXfsstyle elements inDefaultSheetStyleBuilderandMinimalSheetStyleBuilder.OleDb requires these
<xf>elements to be well formed in order to successfully estabilsh a connection to the Excel document.Fixes #759