Documentation Improvements#968
Conversation
…enchmark projects
…nfigure if the underlying stream is closed when the reader is disposed
…, GetSheetInformations and GetColumnNames
…orter API methods
Added `leaveOpen` parameter to `GetDataReader` API methods and renamed parameter `useHeaderRow` to `hasHeaderRow` for clarifying its usage.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several API updates, including renaming useHeaderRow to hasHeaderRow, changing CsvExporter.Export to return int instead of int[], adding a leaveOpen parameter to data readers, caching ordinals in MiniExcelDataReader, and optimizing SharedStringsDiskCache with stackalloc for .NET. Feedback from the review highlights a security risk of unbounded stackalloc in SharedStringsDiskCache that could cause a stack overflow, and notes that the leaveOpen implementation is currently broken because the underlying readers still dispose of the stream. Additionally, potential null reference issues were flagged in MiniExcelDataReader regarding GetOrdinal and the removal of null safety on Current keys.
…hat take a stream as an input
1 participant
OpenXmlImporter,OpenXmlExporter,CsvImporter,CsvExporter, andOpenXmlTemplaterleaveOpenparameter to methods that take a stream as an input for bothOpenXmlImporterandCsvImporterto configure whether it should be closed after the operation is completeduseHeaderRowparameter tohasHeaderRowin all API methods to clarify its usageconfigurationparameter from someOpenXmlImportermethods