Skip to content

Revert "Add local font checking and loading functionality for improve…#60

Merged
shps951023 merged 1 commit intomainfrom
v3
Mar 19, 2026
Merged

Revert "Add local font checking and loading functionality for improve…#60
shps951023 merged 1 commit intomainfrom
v3

Conversation

@shps951023
Copy link
Member

…d font management"

This reverts commit 3f7b5a9.

@shps951023 shps951023 merged commit 4585cf5 into main Mar 19, 2026
1 check passed
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous commit that introduced local font checking and loading capabilities. The changes undo the integration of the Local Font Access API, simplifying the font management back to a direct download approach for the NotoSansSC font. This ensures that the application no longer attempts to use local system fonts, streamlining the font loading mechanism.

Highlights

  • Reverted Local Font Access API Integration: The functionality to check for and load local fonts using the Local Font Access API (introduced in a previous commit) has been entirely removed.
  • Simplified Font Loading Logic: The font loading process has been reverted to its prior state, exclusively downloading the 'NotoSansSC-Regular.ttf' font without attempting to utilize local system fonts.
  • Removed Internationalization Strings: All internationalization keys and their corresponding translations related to local font checking and usage messages have been removed from the application.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous commit, removing the functionality for checking and loading local fonts. The changes correctly remove the C# and JavaScript logic for the Local Font Access API, along with the associated internationalization string resources. The revert is implemented cleanly and consistently across all modified files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant