Bumping minicli dependency on composer.json, adding lock file#9
Merged
WendellAdriel merged 2 commits intomainfrom Jun 13, 2023
Merged
Bumping minicli dependency on composer.json, adding lock file#9WendellAdriel merged 2 commits intomainfrom
WendellAdriel merged 2 commits intomainfrom
Conversation
WendellAdriel
requested changes
Jun 13, 2023
Member
WendellAdriel
left a comment
WendellAdriel
left a comment
There was a problem hiding this comment.
@erikaheidi I removed the lock file because when we had for example version 4.0.6 released the lock file was locking it to 4.0.5, so every time a minor release gets released we need to update the template. Can we bump the version in the composer.json but not include the lock file?
Member
Author
|
Ah! Ok that makes total sense. I will remove it |
WendellAdriel
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the lock file was not being included, so I removed it from gitignore and bumped the Minicli dependency to avoid issues since some features like the services as config are only available on the latest version.