-
Notifications
You must be signed in to change notification settings - Fork 621
Implement new format of the health report #3492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
40b7006 to
8240500
Compare
81b1d00 to
af37ce2
Compare
Praveenrajmani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments.
|
Can we also add an entry in |
To ensure compatibility with older versions of `mc`, `minio` server will continue
to return the health info in the current format. `mc` will internally transform/map
this data to the new data structure required to generate the output in the new
format. The new format is as follows:
- hardware
- servers
- cpus
- meminfo
- perf
- net
- drives
- software
- minio
- info
- servers
- drives
- config
- procinfos
- osinfos
The new format also includes a header at the top of the report that provides
information about the version of the report schema, and looks like:
```json
{
"subnet": {
"health": {
"version": "v1"
}
}
}
```
Following entry already exists. Anything else required?
|
af37ce2 to
fcce588
Compare
fcce588 to
53fb224
Compare
kannappanr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Praveenrajmani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To ensure compatibility with older versions of
mc,minioserver will continueto return the health info in the current format.
mcwill internally transform/mapthis data to the new data structure required to generate the output in the new
format. The new format is as follows:
The new format also includes a header at the top of the report that provides
information about the version of the report schema, and looks like:
{ "subnet": { "health": { "version": "v1" } } }