Skip to content

Conversation

@anjalshireesh
Copy link
Contributor

@anjalshireesh anjalshireesh commented Nov 16, 2020

To ensure compatibility with older versions of mc, minio server will continue
to return the health info in the current format. mc will internally transform/map
this data to the new data structure required to generate the output in the new
format. The new format is as follows:

  • hardware
    • servers
      • cpus
      • meminfo
      • perf
        • net
        • drives
  • software
  • minio
    • info
      • servers
      • drives
    • config
    • procinfos
  • osinfos

The new format also includes a header at the top of the report that provides
information about the version of the report schema, and looks like:

{
    "subnet": {
      "health": {
        "version": "v1"
      }
    }
  }

@anjalshireesh anjalshireesh force-pushed the subnet branch 2 times, most recently from 40b7006 to 8240500 Compare November 16, 2020 11:23
@anjalshireesh anjalshireesh marked this pull request as ready for review November 16, 2020 12:06
@anjalshireesh anjalshireesh force-pushed the subnet branch 5 times, most recently from 81b1d00 to af37ce2 Compare November 23, 2020 08:43
Copy link
Collaborator

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

@Praveenrajmani
Copy link
Collaborator

Praveenrajmani commented Nov 23, 2020

Can we also add an entry in auto-complete.go and also update the structure here in play-obd_20200507160409.json (Not sure where are we using this data) (Ignore)

To ensure compatibility with older versions of `mc`, `minio` server will continue
to return the health info in the current format. `mc` will internally transform/map
this data to the new data structure required to generate the output in the new
format. The new format is as follows:

 - hardware
   - servers
     - cpus
     - meminfo
     - perf
       - net
       - drives
 - software
  - minio
    - info
      - servers
      - drives
    - config
    - procinfos
  - osinfos

The new format also includes a header at the top of the report that provides
information about the version of the report schema, and looks like:

```json
{
    "subnet": {
      "health": {
        "version": "v1"
      }
    }
  }
```
@anjalshireesh
Copy link
Contributor Author

Can we also add an entry in auto-complete.go and also update the structure here in play-obd_20200507160409.json (Not sure where are we using this data) (Ignore)

Following entry already exists. Anything else required?

"/admin/subnet/health": aliasCompleter,

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 3dffa04 into minio:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants