api: Enhance presignedGetObject API to support request params. #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
support-req-params
branch
3 times, most recently
from
2e42226 to
48a0851
Compare
| HttpUrl url = Signer.presignV4(request, region, accessKey, secretKey, expires); | ||
| null, reqParams, null, null, 0); | ||
| HttpUrl url = Signer.presignV4(request, region, accessKey, secretKey, | ||
| expires); |
There was a problem hiding this comment.
You could avoid indentation here as 150 chars long line is allowed in checkstyle.
I already ran @balamurugana a new test is added as well. are you seeing any issue? |
This is needed in cases when certain types of responses are expected for a GET on presigned requests. Supports response header overrides for [ response-expires, response-content-type, response-cache-control, response-content-disposition ]
harshavardhana
force-pushed
the
support-req-params
branch
from
48a0851 to
a6f8a8e
Compare
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in cases when certain types of responses are
expected for a GET on presigned requests.
Supports response header overrides for