Skip to content

fix converting boolean value to XML boolean. #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2022
Merged

fix converting boolean value to XML boolean. #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion minio/deleteobjects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def toxml(self, element):
"""Convert to XML."""
element = Element("Delete")
if self._quiet:
SubElement(element, "Quiet", str(self._quiet))
SubElement(element, "Quiet", "true")
for obj in self._object_list:
obj.toxml(element)
return element
Expand Down
2 changes: 1 addition & 1 deletion minio/lifecycleconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def toxml(self, element):
SubElement(
element,
"ExpiredObjectDeleteMarker",
str(self._expired_object_delete_marker),
str(self._expired_object_delete_marker).lower(),
)
return element

Expand Down
6 changes: 3 additions & 3 deletions tests/unit/remove_objects_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_object_is_list(self, mock_connection):
MockResponse('POST',
'https://localhost:9000/hello?delete=',
{'User-Agent': _DEFAULT_USER_AGENT,
'Content-Md5': u'YcTFWle4oiLJ6sT95FwpdA=='}, 200,
'Content-Md5': u'Te1kmIjQRNNz70DJjsrD8A=='}, 200,
content=b'<Delete/>')
)
client = Minio('localhost:9000')
Expand All @@ -53,7 +53,7 @@ def test_object_is_tuple(self, mock_connection):
MockResponse('POST',
'https://localhost:9000/hello?delete=',
{'User-Agent': _DEFAULT_USER_AGENT,
'Content-Md5': u'YcTFWle4oiLJ6sT95FwpdA=='}, 200,
'Content-Md5': u'Te1kmIjQRNNz70DJjsrD8A=='}, 200,
content=b'<Delete/>')
)
client = Minio('localhost:9000')
Expand All @@ -71,7 +71,7 @@ def test_object_is_iterator(self, mock_connection):
MockResponse('POST',
'https://localhost:9000/hello?delete=',
{'User-Agent': _DEFAULT_USER_AGENT,
'Content-Md5': u'YcTFWle4oiLJ6sT95FwpdA=='}, 200,
'Content-Md5': u'Te1kmIjQRNNz70DJjsrD8A=='}, 200,
content=b'<Delete/>')
)
client = Minio('localhost:9000')
Expand Down