Skip to content

fix lifecycle config rule validation #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2022
Merged

fix lifecycle config rule validation #1217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions minio/lifecycleconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,15 @@ def __init__(self, status, abort_incomplete_multipart_upload=None,
noncurrent_version_transition=None,
transition=None):
check_status(status)
if not rule_filter:
raise ValueError("Rule filter must be provided")
if (not abort_incomplete_multipart_upload and not expiration
and not noncurrent_version_expiration
and not noncurrent_version_transition
and not transition):
raise ValueError(
"at least one of action (AbortIncompleteMultipartUpload, "
"Expiration, NoncurrentVersionExpiration, "
"NoncurrentVersionTransition or Transition) must be specified "
"in a rule")

super().__init__(rule_filter, rule_id)

Expand Down