Skip to content

Do not urldecode Key from list_objects response #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2018
Merged

Do not urldecode Key from list_objects response #670

merged 3 commits into from
Jun 21, 2018

Conversation

DeKe42
Copy link
Contributor

@DeKe42 DeKe42 commented Jun 20, 2018

Fixes #669

@kannappanr kannappanr requested review from donatello and krisis June 20, 2018 16:36
donatello
donatello requested changes Jun 20, 2018
View reviewed changes
Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks to me that the URL decoding is a bug. On line 208 it looks like the directory name is also being (unnecessarily) url decoded - could you update this too?

@DeKe42
Copy link
Contributor Author

DeKe42 commented Jun 21, 2018

Sure, I did not notice that. It's included now.

@kannappanr kannappanr merged commit 3daa2bf into minio:master Jun 21, 2018
@DeKe42 DeKe42 deleted the DeKe42-urldecode branch July 3, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@donatello donatello donatello approved these changes

@krisis krisis krisis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeKe42 @donatello @krisis @kannappanr