Skip to content

Conversation

@harshavardhana
Copy link
Member

Description

fix: add deadline conns and dnsCache for remote transports

Motivation and Context

we need to add deadline conns for remote transport

How to test this PR?

Not easy to test, but this code was missing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minio minio deleted a comment from minio-trusted Mar 21, 2023
@harshavardhana harshavardhana merged commit 0448728 into minio:master Mar 21, 2023
@harshavardhana harshavardhana deleted the remote-transport branch March 21, 2023 15:49
vadmeste pushed a commit to vadmeste/minio that referenced this pull request Apr 2, 2023
@bh4t bh4t added the bugfix label May 23, 2023
vadmeste added a commit to vadmeste/minio that referenced this pull request Jul 13, 2023
* fix: remove objects when there are skipped versions due to ILM in decom (minio#17198)

* disallow EC:0 if not set during server startup (minio#17141)

* heal: Pick maximally occuring modTime in quorum (minio#17071)

* Remove Expect 100-continue in internode communications (minio#17061)

* remove unnecessary log when listing resume fails (minio#17086)

* allow ListObjects() when a prefix is an object (minio#17074)

* Reduce allocations in Walkdir (minio#17036)

* fix: close chan before return in scanner usage updates (minio#16960)

* fix: add deadline conns and dnsCache for remote transports (minio#16865)

* trace: Fix <unknown> func name of requests rejected by max clients (minio#16977)

* Use expontential backoff algo for internode reconnections (minio#17052)

---------

Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Krishnan Parthasarathi <krisis@users.noreply.github.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: jiuker <2818723467@qq.com>
donatello pushed a commit to donatello/minio that referenced this pull request Oct 16, 2023
* fix: remove objects when there are skipped versions due to ILM in decom (minio#17198)

* disallow EC:0 if not set during server startup (minio#17141)

* heal: Pick maximally occuring modTime in quorum (minio#17071)

* Remove Expect 100-continue in internode communications (minio#17061)

* remove unnecessary log when listing resume fails (minio#17086)

* allow ListObjects() when a prefix is an object (minio#17074)

* Reduce allocations in Walkdir (minio#17036)

* fix: close chan before return in scanner usage updates (minio#16960)

* fix: add deadline conns and dnsCache for remote transports (minio#16865)

* trace: Fix <unknown> func name of requests rejected by max clients (minio#16977)

* Use expontential backoff algo for internode reconnections (minio#17052)

---------

Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Krishnan Parthasarathi <krisis@users.noreply.github.com>
Co-authored-by: Klaus Post <klauspost@gmail.com>
Co-authored-by: jiuker <2818723467@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants