Skip to content

Conversation

@vadmeste
Copy link
Member

Description

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@vadmeste
Copy link
Member Author

vadmeste commented May 18, 2023

@klauspost currently parity information are in UserMetadata, thinking to move them outside

 <Contents>
    <Key>go.mod</Key>
    <LastModified>2023-05-16T16:24:19.989Z</LastModified>
    <ETag>"7be5e22578783218f2eda8dbe29a4daf"</ETag>
    <Size>681</Size>
    <Owner>
      <ID>02d6176db174dc93cb1b899f7c6078f08654445fe8cf1b6ce98d8855f66bdbf4</ID>
      <DisplayName>minio</DisplayName>
    </Owner>
    <StorageClass>STANDARD</StorageClass>
    <UserMetadata>
      <K>3</K>
      <M>1</M>
      <content-type>application/octet-stream</content-type>
      <X-Amz-Meta-A>B</X-Amz-Meta-A>
    </UserMetadata>
  </Contents>

@klauspost
Copy link
Contributor

Oh, there was special marshal code. I thought the format was how it was returned.

Yes, move it outside in an <Erasure> tag.

@vadmeste vadmeste force-pushed the add-parity-in-listing branch 2 times, most recently from 8d2afec to 72e0383 Compare May 18, 2023 17:05
@vadmeste
Copy link
Member Author

vadmeste commented May 18, 2023

Yes, move it outside in an tag.

I think <Internal></Internal> is better here, we may have to add something there in the future

@vadmeste vadmeste force-pushed the add-parity-in-listing branch from 72e0383 to 5fa301e Compare May 18, 2023 17:12
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit a30a55f into minio:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants