Test perf#191
Merged
Merged
Conversation
… CLI because those are short lived
Collaborator
Author
|
alright increased test perf mostly by disabling logs and not reading things unnecessarily. like ~2m improvement. the biggest perf barrier remaining is just the time it takes to a) spawn processes and b) that takes a long time because our import time takes eons because of pydantic. so once we transition to noob we can have a switch for running the streamdaq synchronously for testing (and i'm also not sure how much of a perf benefit multiprocessing is here anyway) then we can bring that down further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #172
n_frameparam to capture to only capture a few frames when that's all we care about📚 Documentation preview 📚: https://miniscope-io--191.org.readthedocs.build/en/191/