Skip to content

convert signals from a list to a dict to match slots#212

Merged
sneakers-the-rat merged 1 commit into
mainfrom
signals-as-dict
May 19, 2026
Merged

convert signals from a list to a dict to match slots#212
sneakers-the-rat merged 1 commit into
mainfrom
signals-as-dict

Conversation

@sneakers-the-rat
Copy link
Copy Markdown
Collaborator

@sneakers-the-rat sneakers-the-rat commented May 11, 2026

For some reason the return type of slots was dict[str, Slot] and the return type of signals was list[Signal].

pointlessly different signature for two closely related things. just make them the same.


📚 Documentation preview 📚: https://noob--212.org.readthedocs.build/en/212/

@sneakers-the-rat sneakers-the-rat changed the base branch from slots-signals-accessors to main May 19, 2026 00:34
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 19, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing signals-as-dict (05e6bb4) with main (f046a27)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sneakers-the-rat sneakers-the-rat merged commit 94c346c into main May 19, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant