Skip to content

Get NodeInfo#213

Merged
sneakers-the-rat merged 3 commits into
mainfrom
nodeinfo
May 19, 2026
Merged

Get NodeInfo#213
sneakers-the-rat merged 3 commits into
mainfrom
nodeinfo

Conversation

@sneakers-the-rat
Copy link
Copy Markdown
Collaborator

@sneakers-the-rat sneakers-the-rat commented May 12, 2026

building on prior two PRs, chunking this up for review's sake - do those two first.

adds a mechanism to get the signals and slots from a node spec using the clasmethods.

made one another refactoring change to make signals and slots consistent: i think the more accurate thing to call something in the signals/slots models is "annotation", that's what python calls it, and i think we mostly use type in the specs because that's a more familiar word. "what type of node is it?"


📚 Documentation preview 📚: https://noob--213.org.readthedocs.build/en/213/

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 19, 2026

Merging this PR will improve performance by 13.1%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 7 untouched benchmarks
⏩ 8 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_kitchen_sink_process[ZMQRunner-testing-kitchen-sink] 3.4 ms 3 ms +13.1%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing nodeinfo (36c257a) with main (94c346c)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sneakers-the-rat sneakers-the-rat merged commit 44dcec2 into main May 19, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant