Get NodeInfo#213
Merged
Merged
Conversation
This was referenced May 12, 2026
542dced to
05e6bb4
Compare
97dd15f to
36c257a
Compare
Merging this PR will improve performance by 13.1%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | test_kitchen_sink_process[ZMQRunner-testing-kitchen-sink] |
3.4 ms | 3 ms | +13.1% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing nodeinfo (36c257a) with main (94c346c)
Footnotes
-
8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
building on prior two PRs, chunking this up for review's sake - do those two first.
adds a mechanism to get the signals and slots from a node spec using the clasmethods.
made one another refactoring change to make signals and slots consistent: i think the more accurate thing to call something in the signals/slots models is "annotation", that's what python calls it, and i think we mostly use type in the specs because that's a more familiar word. "what type of node is it?"
📚 Documentation preview 📚: https://noob--213.org.readthedocs.build/en/213/