Skip to content

Represent assets in viewer, fix prefix nesting#233

Merged
sneakers-the-rat merged 3 commits into
mainfrom
viz-assets
Jul 1, 2026
Merged

Represent assets in viewer, fix prefix nesting#233
sneakers-the-rat merged 3 commits into
mainfrom
viz-assets

Conversation

@sneakers-the-rat

@sneakers-the-rat sneakers-the-rat commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Working on merging some of the mio changes -

super simple change, just adding a representation for assets in the viewer, and fixing prefixed nesting of ids


📚 Documentation preview 📚: https://noob--233.org.readthedocs.build/en/233/

@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.13%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 (👁 1) regressed benchmark
✅ 7 untouched benchmarks
⏩ 8 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
👁 Simulation test_kitchen_sink_process[ZMQRunner-testing-kitchen-sink] 2.9 ms 3.4 ms -12.13%

Comparing viz-assets (0bb2167) with main (a476e31)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sneakers-the-rat

Copy link
Copy Markdown
Collaborator Author

perf regression is just random noise, nothing here would touch that.

@sneakers-the-rat sneakers-the-rat merged commit 488055b into main Jul 1, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant