Skip to content

Fix recursive loading in tubes, logging when loading tubes in viewer#236

Merged
sneakers-the-rat merged 6 commits into
mainfrom
recursive-loading
Jul 1, 2026
Merged

Fix recursive loading in tubes, logging when loading tubes in viewer#236
sneakers-the-rat merged 6 commits into
mainfrom
recursive-loading

Conversation

@sneakers-the-rat

@sneakers-the-rat sneakers-the-rat commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

formerly the recursive tube loading wouldn't forward the recursive parameter on, so it wasn't actually recursive, it was just 2 layers. oopsies.

Also added more logging in the viewer for when loading tubes fails - this happens often because people are working on the tubes while it's running, so they are sometimes in invalid states, and currently there is no feedback for that which sucks.

todo:

  • changelog
  • tests

📚 Documentation preview 📚: https://noob--236.org.readthedocs.build/en/236/

@sneakers-the-rat sneakers-the-rat merged commit dd6e949 into main Jul 1, 2026
20 of 21 checks passed
@sneakers-the-rat sneakers-the-rat deleted the recursive-loading branch July 1, 2026 23:48
@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 8 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing recursive-loading (d1d3c7c) with main (c7be157)2

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (d1d3c7c) during the generation of this report, so c7be157 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant