Skip to content

Rename change folder to .changes#205

Merged
miniscruff merged 5 commits intominiscruff:mainfrom
adi611:rename-change-folder
Jan 21, 2022
Merged

Rename change folder to .changes#205
miniscruff merged 5 commits intominiscruff:mainfrom
adi611:rename-change-folder

Conversation

@adi611
Copy link
Copy Markdown
Contributor

@adi611 adi611 commented Jan 21, 2022

Closes #204

Check the following

  • Keep 100% code coverage
  • Be properly formatted
  • Have no linting errors
  • Documentation changes are included
  • Include a change file if expected

Additional context
image

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/miniscruff/changie/CGUe9j7TXBuLoVk4rijaJqjkFazz
✅ Preview: https://changie-git-fork-adi611-rename-change-folder-miniscruff.vercel.app

@miniscruff
Copy link
Copy Markdown
Owner

Sorry the ticket might not have been super clear, but I want to change the default directory name to .changes when the init command is run. Will also need to change the .changie.yml config to use the new directory.

Copy link
Copy Markdown
Owner

@miniscruff miniscruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to adjust the init command, tests and .changie.yml config.

@miniscruff miniscruff changed the title Rename change folder to .change Rename change folder to .changes Jan 21, 2022
@adi611
Copy link
Copy Markdown
Contributor Author

adi611 commented Jan 21, 2022

Need to adjust the init command, tests and .changie.yml config.

@miniscruff How can I adjust tests?

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2022

Codecov Report

Merging #205 (a71bb43) into main (56ed9a8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          693       693           
=========================================
  Hits           693       693           
Impacted Files Coverage Δ
cmd/init.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ed9a8...a71bb43. Read the comment docs.

@miniscruff
Copy link
Copy Markdown
Owner

@miniscruff How can I adjust tests?

Nevermind, it seems there is no test for what the default value is, nor does there really need to be on. So all good. Just be sure to include a changelog fragment and it should be good to go.

@adi611
Copy link
Copy Markdown
Contributor Author

adi611 commented Jan 21, 2022

@miniscruff I need to go to Changed but I am not able to navigate with the arrow keys.
image

@miniscruff
Copy link
Copy Markdown
Owner

miniscruff commented Jan 21, 2022

@miniscruff I need to go to Changed but I am not able to navigate with the arrow keys.

Hmm, that is interesting. Have you tried the vim keys J/K.
Also what OS/terminal are you using cause that feels like an issue related to the prompt ui tool.

@adi611
Copy link
Copy Markdown
Contributor Author

adi611 commented Jan 21, 2022

@miniscruff I need to go to Changed but I am not able to navigate with the arrow keys.

Hmm, that is interesting. Have you tried the vim keys J/K

I am able to navigate using J/K.
image

I am using the go terminal on VS Code in Windows 10.
image

@miniscruff
Copy link
Copy Markdown
Owner

I am using the go terminal on VS Code in Windows 10.

Hmm, ok unfortunate I guess. If you use cmder or the windows terminal it should work as I have used those before.

@adi611
Copy link
Copy Markdown
Contributor Author

adi611 commented Jan 21, 2022

I am using the go terminal on VS Code in Windows 10.

Hmm, ok unfortunate I guess. If you use cmder or the windows terminal it should work as I have used those before.

Oh okay.

Co-authored-by: Ronnie <miniscruff@hey.com>
@adi611
Copy link
Copy Markdown
Contributor Author

adi611 commented Jan 21, 2022

I think it should look into .changes instead of changes for the changelog file. Should i edit the changelog-check.yml file to reflect the same?
image

Copy link
Copy Markdown
Owner

@miniscruff miniscruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I just saw that issue, please do edit the github check.

@miniscruff miniscruff self-requested a review January 21, 2022 20:01
@adi611
Copy link
Copy Markdown
Contributor Author

adi611 commented Jan 21, 2022

Yea I just saw that issue, please do edit the github check.

Okay.

Copy link
Copy Markdown
Owner

@miniscruff miniscruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it should be good this time.

@miniscruff miniscruff merged commit db42ece into miniscruff:main Jan 21, 2022
@adi611
Copy link
Copy Markdown
Contributor Author

adi611 commented Jan 21, 2022

Thanks for giving me this opportunity to learn more about OSS and guiding me through it.

@miniscruff
Copy link
Copy Markdown
Owner

Thanks for giving me this opportunity to learn more about OSS and guiding me through it.

No problem, glad I could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change default folder for changes to .changes to keep in line with other tools being prefixed with a period

2 participants