Skip to content

Module 2 Fixes #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srush merged 2 commits into from
Sep 26, 2023
Merged

Module 2 Fixes #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
034ce65
Import needed file for style
Alwahsh Sep 25, 2023
da79802
Remove wrong reference to Scalar
Alwahsh Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions files_to_sync.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ minitorch/operators.py
minitorch/module.py
minitorch/autodiff.py
minitorch/scalar.py
minitorch/scalar_functions.py
minitorch/module.py
project/run_manual.py
project/run_scalar.py
4 changes: 2 additions & 2 deletions project/graph_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def __init__(self):
self.intermediates = {}

def get_name(self, x):
if not isinstance(x, minitorch.Scalar) and not isinstance(x, minitorch.Tensor):
if not isinstance(x, minitorch.Tensor):
return "constant %s" % (x,)
elif len(x.name) > 15:
if x.name in self.intermediates:
Expand Down Expand Up @@ -72,7 +72,7 @@ def run(self, final):
G.add_edge(self.get_name(input), op, f"{i}")

for input in cur.history.inputs:
if not isinstance(input, minitorch.Scalar) and not isinstance(
if not isinstance(
input, minitorch.Tensor
):
continue
Expand Down