Skip to content

Fix several points of confusion#8

Merged
srush merged 3 commits intomasterfrom
update
Oct 8, 2020
Merged

Fix several points of confusion#8
srush merged 3 commits intomasterfrom
update

Conversation

@srush
Copy link
Copy Markdown
Contributor

@srush srush commented Oct 8, 2020

This PR does the following:

  1. Makes it so that Task 2.3 passes without requiring Task 2.4
  2. Adds some unit tests for the reduce function.
  3. Fixes a bug that caused some broadcasting to assert False on backward.

@srush srush merged commit 710fac5 into master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant