Added more tests for conv1d and tiling#2
Merged
srush merged 2 commits intominitorch:masterfrom Dec 8, 2020
anton164:master
Merged
Added more tests for conv1d and tiling#2srush merged 2 commits intominitorch:masterfrom anton164:master
srush merged 2 commits intominitorch:masterfrom
anton164:master
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current tests I found that it is possible to pass conv1d with an incorrect solution -
simple_backwardaddresses that.The tiling tests should also help students reason about what tiling is intended for.