Update the testsuite to use the new mink/driver-testsuite#113
Merged
stof merged 1 commit intominkphp:masterfrom Oct 1, 2016
Merged
Update the testsuite to use the new mink/driver-testsuite#113stof merged 1 commit intominkphp:masterfrom
stof merged 1 commit intominkphp:masterfrom
Conversation
aik099
reviewed
Oct 1, 2016
| } | ||
| ], | ||
|
|
||
| "repositories": [ |
Member
There was a problem hiding this comment.
I guess once you've merge PR with test suite itself this one won't be needed.
| "require-dev": { | ||
| "symfony/phpunit-bridge": "~2.7|~3.0", | ||
| "silex/silex": "~1.2" | ||
| "mink/driver-testsuite": "dev-http_kernel", |
Member
There was a problem hiding this comment.
I guess once you've merge PR with test suite itself this one won't be needed.
| public function createDriver() | ||
| { | ||
| $client = new Client(require(__DIR__.'/app.php')); | ||
| $client = new Client(new FixturesKernel()); |
Member
There was a problem hiding this comment.
This answers my question on test suite PR on how FixturesKernel would be used 😄
Fixtures overrides to be used with HttpFoundation are now handled in the driver testsuite directly, to ease the maintenance (as they must stay in sync with original fixtures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixtures overrides to be used with HttpFoundation are now handled in the driver testsuite directly, to ease the maintenance (as they must stay in sync with original fixtures).
TODOs: