Skip to content

Add a CI job using the HttpBrowser of BrowserKit and HttpClient#159

Merged
stof merged 2 commits intominkphp:masterfrom
stof:test_http_client
Dec 10, 2021
Merged

Add a CI job using the HttpBrowser of BrowserKit and HttpClient#159
stof merged 2 commits intominkphp:masterfrom
stof:test_http_client

Conversation

@stof
Copy link
Copy Markdown
Member

@stof stof commented Nov 14, 2021

This BrowserKit implementation is the successor of Goutte (Goutte 4.x is only extending that class under the Goutte\Client name without any change). This makes sure we support it.

The new dependencies are not added as dev requirements for now due to the min PHP version (Symfony 4.4 requires PHP 7.1+). This will change once support for those old versions is dropped.

@stof stof marked this pull request as ready for review December 10, 2021 09:56
@stof stof merged commit e6d4c86 into minkphp:master Dec 10, 2021
@stof stof deleted the test_http_client branch December 10, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant