Fix some Travis issues#295
Merged
stof merged 1 commit intominkphp:masterfrom Oct 3, 2018
Merged
Conversation
Member
stof
commented
Oct 3, 2018
stof
commented
- remove testing on HHVM, as they stopped caring about PHP compat
- use the precise infra to run tests on PHP 5.3 (until we drop support, which is not the goal here)
- add testing on PHP 7.2
- use the tested PHP version to run the builtin webserver, as the Trusty infra may not pre-install PHP 5.6 (except for the 5.3 job of course, but that one runs on Precise)
- add testing on PHP 7.2 - remove testing on HHVM as they stopped caring about feature compatibility with PHP - force using the precise image for PHP 5.3 - use the current PHP version to run the test server, except for PHP 5.3
Member
|
What build errors exactly are fixed by this PR? Can you please quote the covered Travis CI error messages? I'm asking, because you might be fixing errors reported in other issues as well. |
Member
Author
|
The second point in my list fixes the fact that the PHP 5.3 job is crashing saying it cannot have PHP 5.3 (https://travis-ci.org/minkphp/MinkSelenium2Driver/jobs/436585583) The other points are cleanups of the test infra (and adding PHP 7.2). |
Member
|
OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.