Rewrite the page manipulation chapter#54
Merged
stof merged 1 commit intominkphp:masterfrom Sep 21, 2015
Merged
Conversation
Member
Author
|
@aik099 please review |
Member
There was a problem hiding this comment.
What action links means? Maybe you wanted to say act on links. The act term is too wide. We can rewrite whole sense to:
The ``NodeElement::click`` and ``NodeElement::press`` methods let you click the links and press the buttons on the page.
Member
|
Sorry for the delay. Now I've reviewed it. |
Member
Author
|
And sorry for the delay. I fixed things you spotted. |
Member
There was a problem hiding this comment.
I'd rather combine links with the text, rather than placing them in parenthesis like so:
... {different drivers} for every browser emulator and providing you with the easy way to {control the browser}, {traverse pages}, {manipulate page elements} or {interact with them} .
The text in {} is also a link to corresponding page, but link text is as we want it instead of linked page name.
Member
|
Today’s review completed. All previously made changes (according to previous review) are good. |
Member
Author
|
I will merge it as is as it already improve things. More improvements can be done later. |
stof
added a commit
that referenced
this pull request
Sep 21, 2015
Rewrite the page manipulation chapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37