Skip to content

#195 - Aggregate Event class rename get_one() and get_all() methods #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2022
Merged

#195 - Aggregate Event class rename get_one() and get_all() methods #203

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20002b1
ISSUE #195
vladyslav-fenchak Feb 16, 2022
d3cb918
ISSUE #195
vladyslav-fenchak Feb 16, 2022
b77ca17
Restyled by isort
restyled-commits Feb 16, 2022
1035e0a
Merge pull request #204 from minos-framework/restyled/issue-195-event…
vladyslav-fenchak Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/core/minos-microservice-aggregate/minos/aggregate/events/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
)

import logging
import warnings
from datetime import (
datetime,
)
Expand Down Expand Up @@ -76,6 +77,10 @@ def __getattr__(self, item: str) -> Any:
raise exc

def get_one(self, name: str, return_diff: bool = False) -> Union[FieldDiff, Any, list[FieldDiff], list[Any]]:
warnings.warn("get_one() method is deprecated by get_attr() and will be removed soon.", DeprecationWarning)
return self.get_attr(name, return_diff)

def get_attr(self, name: str, return_diff: bool = False) -> Union[FieldDiff, Any, list[FieldDiff], list[Any]]:
"""Get first field diff with given name.

:param name: The name of the field diff.
Expand All @@ -86,6 +91,10 @@ def get_one(self, name: str, return_diff: bool = False) -> Union[FieldDiff, Any,
return self.fields_diff.get_one(name, return_diff)

def get_all(self, return_diff: bool = False) -> dict[str, Union[FieldDiff, Any, list[FieldDiff], list[Any]]]:
warnings.warn("get_all() method is deprecated by get_attrs() and will be removed soon.", DeprecationWarning)
return self.get_attrs(return_diff)

def get_attrs(self, return_diff: bool = False) -> dict[str, Union[FieldDiff, Any, list[FieldDiff], list[Any]]]:
"""Get all field diffs with given name.

:param return_diff: If ``True`` the result is returned as field diff instances, otherwise the result is
Expand Down