Skip to content

Conversation

@garciparedes
Copy link
Member

No description provided.

* Now `getitem` is the one that accesses fields and `getattr` uses it.
@garciparedes garciparedes added the enhancement New feature or request label Mar 2, 2022
@garciparedes garciparedes added this to the v0.5.x milestone Mar 2, 2022
@garciparedes garciparedes self-assigned this Mar 2, 2022
@garciparedes garciparedes marked this pull request as draft March 2, 2022 11:01
@garciparedes garciparedes requested a review from a team March 3, 2022 09:43
@garciparedes garciparedes marked this pull request as ready for review March 3, 2022 09:43
Sergio García Prado added 7 commits March 3, 2022 13:12
* Add tests related with `getitem` and `getattr`.
* Minor improvement.
* Add tests related with `getitem` and `getattr`.
* Minor improvement.
* Minor change.
* Add tests.
* Improve `Ref` `getitem` and `getattr`.
* Remove unreachable code.
@garciparedes garciparedes merged commit b8ab66b into 0.5.3 Mar 3, 2022
@garciparedes garciparedes deleted the issue-219-getitem-getattr branch March 3, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix intrinsic bug related with the implementation of __getattr__ and __getitem__ methods at minos.common.Model

4 participants